Skip to content

Tooltip: Preserve changes to title attribute on close#1259

Closed
ijcheung wants to merge 5 commits intojquery:masterfrom
ijcheung:bug_8925
Closed

Tooltip: Preserve changes to title attribute on close#1259
ijcheung wants to merge 5 commits intojquery:masterfrom
ijcheung:bug_8925

Conversation

@ijcheung
Copy link

@ijcheung ijcheung commented Jun 2, 2014

Follow up to the #8925 fix.
Adds the ability to clear a tooltip by setting the title attribute to an empty string.
Also see: forum link

ui/tooltip.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment you suggest removing said:

For mouse events, set to empty string to avoid native tooltip showing up (happens only when removing inside mouseover).

It doesn't look like you're addressing that problem in any way.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just looking for some way to normalize the behavior. I guess this isn't the way to go, any suggestions on that?

@jzaefferer
Copy link
Member

Can you please sign our CLA? http://contribute.jquery.org/CLA/

Apart from the issue commented on above there's also various minor issues, we can get back to those later. Or you can check out our style guide: http://contribute.jquery.org/style-guide/js/

@jzaefferer
Copy link
Member

Also I now noticed that you reference a closed ticket. Can you please create a new ticket describing the problem you're trying to solve?

@ijcheung
Copy link
Author

ijcheung commented Jun 5, 2014

#10092

@ijcheung
Copy link
Author

ijcheung commented Jun 9, 2014

I reread that forum thread. Is this acceptable based on the aria live region hack?

@jzaefferer
Copy link
Member

@ijcheung we're still looking for some details in the ticket discussion.

@tjvantoll
Copy link
Member

Closing PR per the closing of the ticket. @ijcheung if you're interested in continuing with this please respond to @jzaefferer's question.

@tjvantoll tjvantoll closed this Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants